Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLT-5882: Refactor teliod cgi structure #1047

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

LLT-5882: Refactor teliod cgi structure #1047

wants to merge 6 commits into from

Conversation

lcruz99
Copy link
Contributor

@lcruz99 lcruz99 commented Dec 23, 2024 •
edited
Loading

This PR refactors the teliod CGI component, changing the structure focus to be the CGI feature instead of QNAP.

Main changes:

  • Makes QNAP feature a subset of CGI feature.
  • Use URI route as endpoints instead of query strings.
  • Adds test CGI server to Justfile
  • Directory tree structure
  • Removes PID file usage
  • Trace logs added to every http response (debug builds only).

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@lcruz99 lcruz99 force-pushed the LLT-5882_refactor_teliod_cgi_structure branch from e4cd113 to a76fed0 Compare December 30, 2024 15:33
@lcruz99 lcruz99 force-pushed the LLT-5882_refactor_teliod_cgi_structure branch from a76fed0 to 9f8b4f9 Compare January 2, 2025 13:00
@lcruz99 lcruz99 force-pushed the LLT-5882_refactor_teliod_cgi_structure branch from 9f8b4f9 to f020572 Compare January 2, 2025 13:02
@lcruz99 lcruz99 marked this pull request as ready for review January 2, 2025 13:09
@lcruz99 lcruz99 requested a review from a team as a code owner January 2, 2025 13:09
@lcruz99 lcruz99 force-pushed the LLT-5882_refactor_teliod_cgi_structure branch from f020572 to d3a03f0 Compare January 2, 2025 15:18
packgron
packgron reviewed Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@packgron packgron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.0 Nice cleanup, one minor nitpick

clis/teliod/Cargo.toml Outdated
@@ -42,4 +42,5 @@ rand = "0.8.5"
serial_test = "3.2.0"

[features]
qnap = ["const_format", "rust-cgi"]
cgi = ["const_format", "rust-cgi"]
qnap = ["cgi"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: add new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

This was referenced Jan 7, 2025
Closed
Closed
@lcruz99 lcruz99 force-pushed the LLT-5882_refactor_teliod_cgi_structure branch from d3a03f0 to d558afa Compare January 7, 2025 16:52
@lcruz99 lcruz99 mentioned this pull request Jan 7, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@packgron packgron packgron left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcruz99 @packgron